-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(oc-build): Correctly pass Docker build-arg from the build configuration to the Openshift build strategy #2895
fix(oc-build): Correctly pass Docker build-arg from the build configuration to the Openshift build strategy #2895
Conversation
…ration to the Openshift build strategy Signed-off-by: Sun Seng David TAN <sutan@redhat.com>
Eclipse JKube CI ReportStarted new GH workflow run for #2895 (2024-04-11T10:25:35Z) ⚙️ JKube E2E Tests (8644832571)
|
We need to make sure that build args defined as properties still work: https://eclipse.dev/jkube/docs/openshift-maven-plugin/#property-buildargs Could you please confirm this? |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2895 +/- ##
=============================================
+ Coverage 59.36% 70.59% +11.23%
- Complexity 4586 5029 +443
=============================================
Files 500 486 -14
Lines 21211 19509 -1702
Branches 2830 2515 -315
=============================================
+ Hits 12591 13772 +1181
+ Misses 7370 4506 -2864
+ Partials 1250 1231 -19 ☔ View full report in Codecov by Sentry. |
I am currently debugging, but there are some issues. I will create another issue once I can figure out what's going on. For sure there is a problem in kubernetes-maven-plugin when build args are injected to a FROM statement. |
Description
Fixes #2860
Type of change
test, version modification, documentation, etc.)
Checklist